Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global.serialize, tree-based versioning for methods #797

Merged
merged 4 commits into from
Jan 2, 2025
Merged

Global.serialize, tree-based versioning for methods #797

merged 4 commits into from
Jan 2, 2025

Conversation

SethDusek
Copy link
Collaborator

Add Global.serialize method, version methodcalls using ErgoTree version. Also includes a fix for downcast/upcast behavior based on ergoplatform/sigmastate-interpreter#1042

@coveralls
Copy link

coveralls commented Dec 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12516196073

Details

  • 109 of 120 (90.83%) changed or added relevant lines in 19 files are covered.
  • 16 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.006%) to 78.454%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ergotree-ir/src/serialization/method_call.rs 3 4 75.0%
ergotree-ir/src/serialization/sigma_byte_reader.rs 8 9 88.89%
ergotree-ir/src/chain/context.rs 3 5 60.0%
ergotree-interpreter/src/eval/sglobal.rs 7 10 70.0%
ergotree-ir/src/ergo_tree.rs 29 33 87.88%
Files with Coverage Reduction New Missed Lines %
ergo-p2p/src/peer_info.rs 1 68.42%
ergotree-ir/src/serialization/types.rs 4 81.82%
ergotree-ir/src/chain/token.rs 5 72.88%
ergo-p2p/src/peer_spec.rs 6 76.56%
Totals Coverage Status
Change from base Build 12515960184: 0.006%
Covered Lines: 11073
Relevant Lines: 14114
💛 - Coveralls

@SethDusek SethDusek requested a review from kushti December 27, 2024 20:00
@SethDusek SethDusek merged commit 2527351 into ergoplatform:develop Jan 2, 2025
10 of 12 checks passed
@kushti kushti mentioned this pull request Jan 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushti kushti kushti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SethDusek @coveralls @kushti